Add Telegram Group & Fix Warnings#68
Merged
Merged
Conversation
xtclovver
changed the title
xtclovver
reviewed
May 19, 2026
| return SignalOutcome(detected = detected, needsReview = needsReview) | ||
| } | ||
|
|
||
| @Suppress("DEPRECATION") |
| RouteSnapshot( | ||
| destination = route.destination?.toString() | ||
| ?: if (route.isDefaultRoute) "0.0.0.0/0" else "unknown", | ||
| destination = route.destination.toString(), |
Owner
There was a problem hiding this comment.
Потенциальная потеря fallback-логики "0.0.0.0/0"/"unknown"
| @@ -1,3 +1,5 @@ | |||
| @file:Suppress("DEPRECATION") | |||
Owner
There was a problem hiding this comment.
так нельзя делать, на весь файл suppress не вешают
|
|
||
| private object Fallbacks { | ||
| fun geoIp(context: Context, error: Throwable): CategoryResult = CategoryResult( | ||
| fun geoIp(@Suppress("UNUSED_PARAMETER") context: Context, error: Throwable): CategoryResult = CategoryResult( |
Owner
There was a problem hiding this comment.
если unused то убирать надо, а не глушить warning
| findings = listOf(Finding(error.message ?: error::class.java.simpleName, isError = true)), | ||
| ) | ||
| fun indirect(context: Context, error: Throwable): CategoryResult = CategoryResult( | ||
| fun indirect(@Suppress("UNUSED_PARAMETER") context: Context, error: Throwable): CategoryResult = CategoryResult( |
| findings = listOf(Finding(error.message ?: error::class.java.simpleName, isError = true)), | ||
| ) | ||
| fun location(context: Context, error: Throwable): CategoryResult = CategoryResult( | ||
| fun location(@Suppress("UNUSED_PARAMETER") context: Context, error: Throwable): CategoryResult = CategoryResult( |
| findings = listOf(Finding(error.message ?: error::class.java.simpleName, isError = true)), | ||
| ) | ||
| fun native(context: Context, error: Throwable): CategoryResult = CategoryResult( | ||
| fun native(@Suppress("UNUSED_PARAMETER") context: Context, error: Throwable): CategoryResult = CategoryResult( |
| ) | ||
| } | ||
|
|
||
| @Suppress("DEPRECATION") |
Owner
There was a problem hiding this comment.
убрать/передать функцию вместо глушения ошибки
| private fun ensureCardVisible( | ||
| card: MaterialCardView, | ||
| animate: Boolean = true, | ||
| @Suppress("UNUSED_PARAMETER") animate: Boolean = true, |
Owner
There was a problem hiding this comment.
он более не используется, убирать надо просто
Owner
|
@ArThirtyFour Я мердж сделал, комментарии тебе на будущее просто. Warnings исправлять надо, а не suppress делать. Эти suppress потом могут мешать в нахождении проблем, особенно suppress на весь файл (в первый и последних раз принимаю с таким suppress). Я сам доработаю что пометил |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Я уже писал ранее в Matrix краткенько зачем нужна , но напишу здесь.
Как я посчитал, для тех нормисов , которые пока не познали мощь матрикса , и пока сидят в тг.
Ну и еще починил там варниги со стороны комплятора. И теперь сборка не выдает преупреждения.